Add RegisterAll API to enable monitoring collections of key-values for refresh
#574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otnetProvider into ajusupovic/collection-monitoring
…otnetProvider into ajusupovic/collection-monitoring
…otnetProvider into ajusupovic/collection-monitoring
…, separate selectors, add new methods to support new logic
This was
linked to
issues
Jul 15, 2024
…/Azure/AppConfiguration-DotnetProvider into ajusupovic/collection-monitoring
…otnetProvider into ajusupovic/collection-monitoring
| { | ||
| internal class ConfigurationSettingPageableManager | ||
| { | ||
| public virtual IAsyncEnumerable<Page<ConfigurationSetting>> GetPages(AsyncPageable<ConfigurationSetting> pageable, IEnumerable<MatchConditions> matchConditions) |
There was a problem hiding this comment.
Why are these methods virtual?
There was a problem hiding this comment.
Thanks, I didn't document this anywhere so good callout. The approach recommended by the SDK team for testing the AsPages extension with MatchConditions as seen here was to create a virtual method that we could override in the tests using the MockConfigurationSettingPageableManager class. Because Moq doesn't let you mock extension methods, this was the only approach that we came up with. Any details I missed are probably in the issue I linked in the PR description.
…otnetProvider into ajusupovic/collection-monitoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the new
RegisterAllAPI to monitor any key-values added withAzureAppConfigurationOptions.Selectfor refresh as a collection, but it will also begin monitoring feature flags as a collection instead of on an individual basis. Consequently, feature flag changes will no longer be logged on an individual basis. This solves an existing issue.